Skip to content

Comments

[FIX] hasMatchingTest 수정 (#378)#379

Merged
lingard1234 merged 1 commit intodevfrom
fix/378-hasMatchingTest
Feb 11, 2026
Merged

[FIX] hasMatchingTest 수정 (#378)#379
lingard1234 merged 1 commit intodevfrom
fix/378-hasMatchingTest

Conversation

@lingard1234
Copy link
Contributor

Summary

hasMatchingTest 참조 수정

Changes

hasMatchingTest에서 userMatching으로 수정

Type of Change

  • Bug fix (기존 기능에 영향을 주지 않는 버그 수정)
  • New feature (기존 기능에 영향을 주지 않는 새로운 기능 추가)
  • Breaking change (기존 기능에 영향을 주는 수정)
  • Refactoring (기능 변경 없는 코드 개선)
  • Documentation (문서 수정)
  • Chore (빌드, 설정 등 기타 변경)
  • Release (develop → main 배포)

Related Issues

참고 사항

@lingard1234 lingard1234 self-assigned this Feb 11, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @lingard1234, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 사용자 마이페이지에서 매칭 테스트 완료 여부를 정확하게 표시하기 위한 버그를 수정합니다. 기존에 잘못된 저장소를 참조하던 로직을 올바른 사용자 매칭 상세 저장소로 변경하여, 사용자의 매칭 상태가 정확하게 반영되도록 개선했습니다.

Highlights

  • 매칭 테스트 로직 수정: 사용자의 매칭 테스트 완료 여부를 확인하는 로직이 matchCampaignHistoryRepository에서 userMatchingDetailRepository를 사용하도록 수정되었습니다.
  • 불필요한 의존성 제거: UserService에서 더 이상 사용되지 않는 MatchCampaignHistoryRepository import와 필드가 제거되었습니다.
Changelog
  • src/main/java/com/example/RealMatch/user/application/service/UserService.java
    • MatchCampaignHistoryRepository import가 제거되었습니다.
    • UserService 클래스에서 matchCampaignHistoryRepository 필드가 제거되었습니다.
    • getMyPage 메서드 내 hasMatchingTest 변수의 로직이 userMatchingDetailRepository.existsByUserIdAndIsDeprecatedFalse(userId)를 사용하도록 변경되었습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@lingard1234 lingard1234 merged commit e18f7fc into dev Feb 11, 2026
1 check passed
@lingard1234 lingard1234 deleted the fix/378-hasMatchingTest branch February 11, 2026 12:37
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이 PR은 hasMatchingTest 플래그의 로직을 수정하여, MatchCampaignHistoryRepository 대신 UserMatchingDetailRepository를 사용하도록 변경합니다. 이를 통해 매칭 검사 여부를 확인하는 기준이 다른 기능들과 일관성을 갖게 되었으며, 관련된 버그가 수정되었습니다. 변경 사항은 정확하며, 불필요한 의존성 제거도 함께 이루어져 코드 품질이 향상되었습니다. 좋은 수정입니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant