Skip to content

Comments

feat: update interval logic for devnet3#1218

Merged
KolbyML merged 7 commits intoReamLabs:masterfrom
shariqnaiyer:feature/shariqnaiyer/devnet-3-pass
Feb 20, 2026
Merged

feat: update interval logic for devnet3#1218
KolbyML merged 7 commits intoReamLabs:masterfrom
shariqnaiyer:feature/shariqnaiyer/devnet-3-pass

Conversation

@shariqnaiyer
Copy link
Contributor

@shariqnaiyer shariqnaiyer commented Feb 11, 2026

What was wrong?

We are using intervals per slot constant in fork choice but we are using the wrong value of 4 for devnet 3.

Also contains fixes for interval logic for devnet 3.

How was it fixed?

Updating it to 5 for devnet3.

To-Do

@shariqnaiyer shariqnaiyer marked this pull request as draft February 11, 2026 03:53
@shariqnaiyer shariqnaiyer changed the title fix: update intervals per slot to 5 for devnet 3 fix: update INTERVALS_PER_SLOT to 5 for devnet 3 and fix tick time formula Feb 17, 2026
@shariqnaiyer shariqnaiyer changed the title fix: update INTERVALS_PER_SLOT to 5 for devnet 3 and fix tick time formula fix: INTERVALS_PER_SLOT to 5 for devnet 3 and fix tick time formula Feb 17, 2026
@shariqnaiyer shariqnaiyer changed the title fix: INTERVALS_PER_SLOT to 5 for devnet 3 and fix tick time formula fix: update INTERVALS_PER_SLOT to 5 for devnet 3 and fix tick time formula Feb 17, 2026
@shariqnaiyer shariqnaiyer marked this pull request as ready for review February 17, 2026 04:58
@shariqnaiyer shariqnaiyer force-pushed the feature/shariqnaiyer/devnet-3-pass branch from eb931d2 to daa55b8 Compare February 17, 2026 05:04
@shariqnaiyer shariqnaiyer changed the title fix: update INTERVALS_PER_SLOT to 5 for devnet 3 and fix tick time formula fix: set INTERVALS_PER_SLOT to 5 for devnet3 and correct tick time formula Feb 17, 2026
@KolbyML KolbyML marked this pull request as draft February 17, 2026 06:55
@shariqnaiyer shariqnaiyer force-pushed the feature/shariqnaiyer/devnet-3-pass branch from daa55b8 to 0ac65c8 Compare February 19, 2026 02:42
@shariqnaiyer shariqnaiyer changed the title fix: set INTERVALS_PER_SLOT to 5 for devnet3 and correct tick time formula fix: update interval logic for devnet3 Feb 20, 2026
@shariqnaiyer shariqnaiyer marked this pull request as ready for review February 20, 2026 04:05
Copy link
Contributor

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming CI passes I will merge it

@KolbyML KolbyML changed the title fix: update interval logic for devnet3 feat: update interval logic for devnet3 Feb 20, 2026
@KolbyML KolbyML merged commit a292a17 into ReamLabs:master Feb 20, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants