feat: added tests for checkpoint_sync#1236
Open
Patchoulis wants to merge 6 commits intoReamLabs:masterfrom
Open
feat: added tests for checkpoint_sync#1236Patchoulis wants to merge 6 commits intoReamLabs:masterfrom
Patchoulis wants to merge 6 commits intoReamLabs:masterfrom
Conversation
Patchoulis
requested review from
Kayden-ML,
KolbyML,
shariqnaiyer and
varun-doshi
as code owners
Patchoulis
changed the title
Patchoulis
force-pushed
the
checkpoint_sync_tests
branch
from
95021cd to
5cb92a1
Compare
Patchoulis
force-pushed
the
checkpoint_sync_tests
branch
from
5cb92a1 to
86287a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
fixes #1145. Essentially just adds the test within the spec for the checkpoint.
How was it fixed?
On top of what was just in the spec, I added an extra assertion to ensure that the deserialization actually matches what we expect it to be.
To-Do