refactor: fn sample_store is duplicated in many tests#1238
Merged
KolbyML merged 6 commits intoReamLabs:masterfrom Feb 23, 2026
Merged
refactor: fn sample_store is duplicated in many tests#1238KolbyML merged 6 commits intoReamLabs:masterfrom
KolbyML merged 6 commits intoReamLabs:masterfrom
Conversation
shariqnaiyer
requested review from
Kayden-ML,
KolbyML and
varun-doshi
as code owners
shariqnaiyer
changed the title
KolbyML
approved these changes
Feb 23, 2026
Contributor
KolbyML
left a comment
KolbyML
left a comment
There was a problem hiding this comment.
Looks good, thanks for the changes
Kayden-ML
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Every set of tests we implement from the spec initialize this function separately and it is going to be used in many other places when we bring tests over. I copy pasting the function is bloat.
How was it fixed?
Deduplicate to a test utils module in store.rs
To-Do