Skip to content

fix: handle case when tally is equal in common_highest_checkpoint #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KolbyML merged 1 commit into from
Feb 23, 2026
Merged

fix: handle case when tally is equal in common_highest_checkpoint #1239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions crates/networking/network_state/lean/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,6 @@ impl NetworkState {

pub fn common_highest_checkpoint(&self) -> Option<Checkpoint> {
let peer_table = self.peer_table.lock();
let mut common_checkpoint: Option<Checkpoint> = None;

let mut checkpoint_tally: HashMap<Checkpoint, usize> = HashMap::new();
for peer in peer_table.values() {
if let (ConnectionState::Connected, Some(head_checkpoint)) =
Expand All @@ -92,15 +90,11 @@ impl NetworkState {
*checkpoint_tally.entry(*head_checkpoint).or_insert(0) += 1;
}
}
let mut highest_tally = 0;
for (checkpoint, tally) in checkpoint_tally {
if tally > highest_tally {
highest_tally = tally;
common_checkpoint = Some(checkpoint);
}
}

common_checkpoint
checkpoint_tally
.into_iter()
.max_by_key(|(checkpoint, tally)| (*tally, checkpoint.slot))
.map(|(checkpoint, _)| checkpoint)
}

pub fn successful_response_from_peer(&self, peer_id: PeerId) {
Expand Down