Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in-need parameter on main businesses page #378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brianjhanson
Copy link
Contributor

Not sure this is the best way to fix this, but I think it's at least a way.

This PR alters the searchingInNeed function within the businesses template to return 'false' both when the location.pathname is /businesses/all and when it is /businesses. The latter should only match when /businesses is the only URL path and should account for an optional trailing slash.

Fixes #370

Pages/Interfaces that will change

Screenshots / video of changes

CleanShot 2020-11-13 at 07 48 59

CleanShot 2020-11-13 at 07 49 10

Steps to test

  1. Go to rebuildblackbusiness.com and click "SEE BUSINESSES"
  2. Businesses displayed should match the businesses displayed on the /businesses/all page
  3. Pagination should display many more than 12 pages.

@netlify
Copy link

netlify bot commented Nov 13, 2020

Deploy request for rebuild-black-business accepted.

Accepted with commit b5ee6b5

https://app.netlify.com/sites/rebuild-black-business/deploys/5fae8f2c0da4a100072b803d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix Home Page Shows Incorrect Listings
1 participant