Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data retrival #33

Merged
merged 16 commits into from
Feb 13, 2024
Merged

New data retrival #33

merged 16 commits into from
Feb 13, 2024

Conversation

Lukasaurus11
Copy link
Collaborator

  • Changed the API code, to allow testing functionality for every function
  • Added functionality to get bulk dataset
  • Split the get_data.py file into two files
  • Updated tests accordingly

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill add test comment documentation.
eg:
"""
GIVEN a Account model
WHEN a new Account is created
THEN check the name, account_number, balance, currency, status and created_at fields are defined correctly
"""

@gabrieldeolaguibel gabrieldeolaguibel merged commit d1f5578 into main Feb 13, 2024
1 check passed
@gabrieldeolaguibel gabrieldeolaguibel deleted the new_data_retrival branch February 13, 2024 14:38
@gabrieldeolaguibel
Copy link
Collaborator

Great, improvement of the data extraction process. The data retrieved is now quite plentiful.
I will approve the PR and can add some simple documentation comments to each of the unit tests Great work sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants