Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ReadyState conformance to Sendable #20

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Ashok28
Copy link
Contributor

@Ashok28 Ashok28 commented Nov 26, 2024

Accessing ReadyState from outside the EventSourceActor results in a warning in Swift 5 and becomes an error in Swift 6.

This PR updates the ReadyState enum to conform to the Sendable protocol, allowing it to cross actor boundaries safely.

@Recouse
Copy link
Owner

Recouse commented Nov 26, 2024

Hm, interesting, I haven't seen any warnings or errors on Xcode 16. I was wondering why the Swift Package Index says that the package has data race safety errors.

Thank you for the fix!

@Recouse Recouse merged commit 11a4d2a into Recouse:main Nov 26, 2024
3 checks passed
@Ashok28 Ashok28 deleted the concurrency-warnings branch November 28, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants