FIX handling of external urls

RecuencoJones · Nov 28, 2022 · 6fcb384 · 6fcb384
1 parent fe90a57
commit 6fcb384
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/background/ipc.js b/src/background/ipc.js
@@ -197,6 +197,7 @@ function registerIpcHandlers() {
 
   ipcMain.on('openGitHubRepository', openGitHubRepository);
   ipcMain.handle('openGitHubRepository', openGitHubRepository);
+  ipcMain.handle('openUrl', (event, url) => shell.openExternal(url));
 }
 
 module.exports = { registerIpcHandlers };
diff --git a/src/background/preload.js b/src/background/preload.js
@@ -24,6 +24,7 @@ contextBridge.exposeInMainWorld('api', {
     'getContextOverview',
     'getPreferences',
     'savePreferences',
+    'openUrl',
     'openGitHubRepository'
   ),
   async subscribeToContainerLogs(contextName, podName, containerName, fn) {

diff --git a/src/foreground/components/resource-table-adapters/Ingresses.vue b/src/foreground/components/resource-table-adapters/Ingresses.vue
@@ -12,7 +12,7 @@
         <td>{{ item.metadata.name }}</td>
         <td>
           <template v-for="rule of formatRules(item.spec)" :key="rule">
-            <a :href="rule.url" target="_blank" rel="noopener noreferrer">{{ rule.url }}</a> &rarr; {{ rule.service }}
+            <a href="#" @click="openUrl(rule.url)">{{ rule.url }}</a> &rarr; {{ rule.service }}
             <br/>
           </template>
         </td>
@@ -47,6 +47,9 @@ export default {
     },
     handleSelect(item) {
       this.$emit('select', item);
+    },
+    async openUrl(url) {
+      await api.openUrl(url);
     }
   }
 }