Added automatic check of homework #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Guy, |
Signed-off-by: Guy Hartuv <ghartuv@redhat.com>
Acepresso
force-pushed
the
check-homework
branch
from
35f5bbb
to
bfbb78f
Compare
shiramax
requested changes
Oct 24, 2020
|
|
||
| Guidelines: | ||
| - Student's exercise files should be placed in the same dir as this test. | ||
| - Test names are in the form: test_<topic>_<exc>.py |
There was a problem hiding this comment.
it's not Ideal,
I would change it so I could give a file path to this test
There was a problem hiding this comment.
Sure. Will add that.
Automatic check of student's homework. Utilized using pytest framework. Signed-off-by: Guy Hartuv <ghartuv@redhat.com>
Acepresso
force-pushed
the
check-homework
branch
from
bfbb78f
to
f3075b2
Compare
|
@jaroman-tic any news about this PR? |
|
@shiramax I did not have the capacity to work on it. I do want to complete this task but if it is needed sooner it is ok by me to pass the ownership. |
|
@jaroman-tic :( |
|
Sorry @shiramax :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilized using pytest framework.
Signed-off-by: Guy Hartuv ghartuv@redhat.com