Fix layout #454
Fix layout #454
Conversation
src/app/layout.tsx
Outdated
| useEffect(() => { | ||
| const fetchPartials = async () => { | ||
| const headerResponse = await fetch(`/api/chrome/rh-universal-nav-header`); | ||
| const footerResponse = await fetch(`/api/chrome/rh-unified-footer`); |
There was a problem hiding this comment.
could you fetch the header and footer in parallel instead of sequentially ?
| @@ -32,7 +32,8 @@ | |||
| })(); | |||
| </script> | |||
| <script> | |||
| (function (env) { | |||
| (function () { | |||
There was a problem hiding this comment.
are we still using this file? for development perhaps?
There was a problem hiding this comment.
This file is loaded before the javascript kicks in.
There was a problem hiding this comment.
This file is not used. The JS does not have to kick in, the site is statically generated. Next.js creates ints own index file unless the server ins misconfigured.
|
|
||
| location /remote { | ||
| rewrite ^/remote/(.*)$ /$1 break; | ||
| proxy_pass https://developers.redhat.com; |
There was a problem hiding this comment.
Is any of this still required?
It looks like we moved away from nginx loading to loading it from the frontend
| @@ -32,7 +32,8 @@ | |||
| })(); | |||
| </script> | |||
| <script> | |||
| (function (env) { | |||
| (function () { | |||
There was a problem hiding this comment.
This file is not used. The JS does not have to kick in, the site is statically generated. Next.js creates ints own index file unless the server ins misconfigured.
|
|
||
| export default function RootLayout({ | ||
| children, | ||
| }: Readonly<{ | ||
| children: React.ReactNode; | ||
| }>) { | ||
| const [header, setHeader] = useState<string | undefined>(); |
There was a problem hiding this comment.
We need to fix this using actual web components. This is bad. Unless the header and footer are not web components but ESI. In which case we are done for.
There was a problem hiding this comment.
AFAIK they are ESI tags. There's webcomponent for these partials, but they are missing the content.
Description
Since we moved to Next.js we have to adjust the loading of navigation and footer. We can utilize HTML partials on developers site to load both content and JS files.