Skip to content

Commit

Permalink
Merge pull request #2018 from bastilian/remove_fecconfig_clutter
Browse files Browse the repository at this point in the history
fix(config): Remove obsolete fec config bits
  • Loading branch information
Hyperkid123 authored Jun 14, 2024
2 parents e1e1559 + c447203 commit 2c25d89
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
1 change: 0 additions & 1 deletion packages/config-utils/src/federated-modules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ const createIncludes = (eager = false): { [module: string]: WebpackSharedConfig
'@redhat-cloud-services/chrome': { singleton: true },
axios: {},
lodash: {},
'redux-promise-middleware': {},
react: { singleton: true, eager },
'react-dom': { singleton: true, eager },
});
Expand Down
2 changes: 0 additions & 2 deletions packages/config/src/bin/empty.ts

This file was deleted.

7 changes: 0 additions & 7 deletions packages/config/src/bin/webpack.plugins.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
const webpack = require('webpack');
const { resolve } = require('path');
import { LogType, fecLogger, federatedModules, generatePFSharedAssetsList } from '@redhat-cloud-services/frontend-components-config-utilities';
import FECConfiguration from '../lib/fec.config';

Expand Down Expand Up @@ -33,10 +31,5 @@ const plugins = [
}),
];

// Save 20kb of bundle size in prod
if (process.env.NODE_ENV === 'production') {
plugins.push(new webpack.NormalModuleReplacementPlugin(/redux-logger/, resolve(__dirname, './empty.js')));
}

export default plugins;
module.exports = plugins;

0 comments on commit 2c25d89

Please sign in to comment.