Skip to content

Commit

Permalink
fix: localize name filter strings
Browse files Browse the repository at this point in the history
  • Loading branch information
InsaneZein committed Dec 18, 2024
1 parent 516279f commit 0832973
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions src/Messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -2518,6 +2518,11 @@ export default defineMessages({
description: 'confirm button for deleting role',
defaultMessage: 'Delete role',
},
nameFilterPlaceholder: {
id: 'nameFilterPlaceholder',
description: 'placeholder for name filter',
defaultMessage: 'Filter by name',
},
deleteRolesAction: {
id: 'deleteRolesAction',
description: 'delete roles',
Expand Down
4 changes: 2 additions & 2 deletions src/smart-components/role/RolesTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,8 @@ const RolesTable: React.FunctionComponent<RolesTableProps> = ({ selectedRole })
filters={
<DataViewTextFilter
filterId="display_name"
title="Name"
placeholder="Filter by name"
title={intl.formatMessage(messages.name)}
placeholder={intl.formatMessage(messages.nameFilterPlaceholder)}
ouiaId={`${ouiaId}-name-filter`}
onChange={(_e, value) => {
onSetFilters({ display_name: value });
Expand Down

0 comments on commit 0832973

Please sign in to comment.