Pull in rhecosystem changes (need FEO support) #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he-user-page-of-the-IAM-console-to-add-the-activate/deactivate-user-feature Modified the user page to add activate user or deactivate user feature
…he-RBAC-console-applying-new-UXD-to-support-bulk-actions-for-activate/deactivate-users Modified the activate/deactivate user feature, and added the invite users feature
…-issue RHBKAAS-89: Fix cors issue
…eference-to-UGC RHBKAAS-91: Remove reference to UGC for FEDRAMP
…ch-to-change-the-isAdmin-status-in-the-user-table RHBKAAS-92: Add switch to change the is admin status in the user table
…es-when-user-is-not-org-admin RHBKAAS-79: Hide pages when user is not org admin
…9-add-ability-to-avoid-current-users-to-deactivate-themselves RHBKAAS-139: Add ability to avoid current users to deactivate themselves
Add beta build alias
Fix getBaseUrl not working
Fix typo in get api url
fix user-helper url bug
…ates update build commands
florkbr
changed the title
florkbr
force-pushed
the
pull-in-rhecosystem-changes
branch
from
8298e2f to
4e8fa84
Compare
florkbr
changed the title
florkbr
commented
Jul 18, 2024
| setDeleteInfo({ | ||
| title: removeText, | ||
| confirmButtonLabel: removeText, | ||
| text: removeModalText( | ||
| multipleMembersSelected ? selectedMembers.length : selectedMembers[0].uuid, | ||
| multipleMembersSelected ? selectedMembers.length : chrome.isFedramp ? selectedMembers[0].label : selectedMembers[0].uuid, |
There was a problem hiding this comment.
@fhlavac I think I recall you converting us to using UUID (no worries if I'm wrong). Can you see if this logic seems valid or if label will no longer work with the changes we've made in master?
There was a problem hiding this comment.
@fhlavac any insights here?
florkbr
force-pushed
the
pull-in-rhecosystem-changes
branch
from
4e8fa84 to
b6f0e35
Compare
florkbr
commented
Jul 18, 2024
| @@ -0,0 +1,4 @@ | |||
| export const isEphem = insights.chrome.getEnvironment() === 'ephem'; | |||
There was a problem hiding this comment.
This is a bit different from our chrome.isFedramp helper as we will use this to lookup the correct invite API base URL (from a static file in each env).
aneelac22
reviewed
Jul 19, 2024
Hyperkid123
reviewed
Jul 19, 2024
| @@ -8,6 +9,145 @@ const principalStatusApiMap = { | |||
| Inactive: 'disabled', | |||
| All: 'all', | |||
| }; | |||
|
|
|||
| const getBaseUrl = (url) => { | |||
There was a problem hiding this comment.
Note. We should be feeding it from chrome service and configure a env variable in the OC namespace. @florkbr can you create a ticket for this?
There was a problem hiding this comment.
fhlavac
reviewed
Jul 19, 2024
florkbr
force-pushed
the
pull-in-rhecosystem-changes
branch
from
0b6a419 to
c011467
Compare
Hyperkid123
reviewed
Jul 23, 2024
There was a problem hiding this comment.
Looks good now. I'll let @fhlavac and co to check if this works fine in commercial env.
florkbr
force-pushed
the
pull-in-rhecosystem-changes
branch
2 times, most recently
from
586cff7 to
64d2279
Compare
florkbr
force-pushed
the
pull-in-rhecosystem-changes
branch
from
64d2279 to
d354f56
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We originally migrated rbac UI in-boundary via a different public repo: https://github.com/RHEcosystemAppEng/insights-rbac-ui. That repo is out of date with this one and also has changes on top of it for itless.
I've attempted to merge those changes back into rbac-ui in this PR for maintainability, consistency with what we do in our other repos, and to fast forward the UI. We will need extensive regression testing to ensure this PR does not regress either env.
I've opted NOT to squash these commits for historical reasons (as these changes were made by other engineers). I imagine we will also have some follow up around best practices, tech debt, etc.
Screenshots
N/A - ideally in commercial we should see no change
Checklist ☑️