Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Remove User Modal #1677

Closed
wants to merge 13 commits into from
Closed

add Remove User Modal #1677

wants to merge 13 commits into from

Conversation

InsaneZein
Copy link
Contributor

Description

This adds the Remove User from User Groups modal. The v2 api is not ready, so in the meantime there's just a console.log message when you click the Remove button.

RHCLOUD-34811


Screenshots

Screenshot from 2024-10-18 09-32-57


Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

@InsaneZein InsaneZein requested a review from a team October 18, 2024 14:37
InsaneZein and others added 13 commits October 18, 2024 10:47
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Bumps [@redhat-cloud-services/frontend-components-config](https://github.com/RedHatInsights/frontend-components) from 6.2.2 to 6.3.1.
- [Commits](https://github.com/RedHatInsights/frontend-components/commits)

---
updated-dependencies:
- dependency-name: "@redhat-cloud-services/frontend-components-config"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 47.26%. Comparing base (5745924) to head (e12460f).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
.../smart-components/access-management/UsersTable.tsx 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1677      +/-   ##
==========================================
- Coverage   47.44%   47.26%   -0.19%     
==========================================
  Files         178      178              
  Lines        4717     4735      +18     
  Branches     1348     1351       +3     
==========================================
  Hits         2238     2238              
- Misses       2266     2284      +18     
  Partials      213      213              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@InsaneZein
Copy link
Contributor Author

closing in favor of #1678

@InsaneZein InsaneZein closed this Oct 18, 2024
@InsaneZein InsaneZein deleted the remove-user-modal branch October 18, 2024 19:43
@InsaneZein InsaneZein restored the remove-user-modal branch October 22, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants