Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve routing in RBAC workspaces #1735

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Improve routing in RBAC workspaces #1735

merged 4 commits into from
Jan 3, 2025

Conversation

fhlavac
Copy link
Contributor

@fhlavac fhlavac commented Dec 16, 2024 •
edited
Loading

Description

  • mapped create user group wizard to URL (/access-management/users-and-user-groups/user-groups/create-user-group)
  • mapped tabs to URL instead of query params (/access-management/users-and-user-groups/users, /access-management/users-and-user-groups/user-groups)
  • cleaned some code and translations + minor fixes
  • updated tests

RHCLOUD-36537

Screenshots

Before:

Snímek obrazovky 2025-01-02 v 17 37 05

After:

Snímek obrazovky 2025-01-02 v 17 32 53

Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

@fhlavac fhlavac changed the title fix: init Map to URL Dec 16, 2024
@fhlavac fhlavac changed the title Map to URL Improve routing in RBAC workspaces Jan 2, 2025
@fhlavac fhlavac marked this pull request as ready for review January 2, 2025 16:41
@fhlavac fhlavac requested a review from a team as a code owner January 2, 2025 16:41
@karelhala karelhala merged commit 7e4dc40 into RedHatInsights:master Jan 3, 2025
9 of 11 checks passed
@fhlavac fhlavac mentioned this pull request Jan 7, 2025
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InsaneZein InsaneZein InsaneZein approved these changes

@karelhala karelhala karelhala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhlavac @karelhala @InsaneZein