Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering for workspaces #1749

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Add filtering for workspaces #1749

merged 2 commits into from
Jan 29, 2025

Conversation

apinkert
Copy link
Contributor

For RHCLOUD-35021. After speaking with @karelhala, we decided the other filters were not necessary for this PR (creator hasn't been implemented yet and parent search was redundant).

From our conversation:

  • A filtered workspace should show its parents
  • A filtered workspace should not show its children
Screen.Recording.2025-01-23.at.11.20.07.AM.mov

@apinkert apinkert requested a review from a team as a code owner January 23, 2025 16:25
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 40.56%. Comparing base (186626a) to head (d4e071e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...smart-components/workspaces/WorkspaceListTable.tsx 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
- Coverage   41.25%   40.56%   -0.70%     
==========================================
  Files         201      203       +2     
  Lines        5565     5663      +98     
  Branches     1457     1481      +24     
==========================================
+ Hits         2296     2297       +1     
- Misses       3053     3150      +97     
  Partials      216      216              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karelhala karelhala merged commit 4fa9dae into master Jan 29, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants