Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 support #473

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Drop Python 3.8 support #473

merged 1 commit into from
Oct 25, 2023

Conversation

ogajduse
Copy link
Member

Problem statement

In #471, we have hit issues running wrapanapi unit tests with Python 3.8. Errors related to typing library were showing up.

Solution

Unit tests using Python 3.9 do not throw any error, therefore we can drop Python 3.8.
After talking to @mshriver, we should be good to drop Python 3.8 since all known wrapanapi users are using 3.9+.

@ogajduse ogajduse requested a review from mshriver October 25, 2023 14:45
Copy link
Collaborator

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with dropping 3.8 support here even if py3.8 is still supported in general.

Known consumers are on py3.9+ at this point, and we otherwise have enough changes on master to warrant a minor release (including dropping py3.7).

@mshriver mshriver merged commit 4c4d01b into RedHatQE:master Oct 25, 2023
4 checks passed
@ogajduse ogajduse deleted the drop-py38 branch October 26, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants