Merged
Conversation
jyejare
approved these changes
Oct 25, 2023
mshriver
approved these changes
Oct 25, 2023
Collaborator
mshriver
left a comment
mshriver
left a comment
There was a problem hiding this comment.
Agree with dropping 3.8 support here even if py3.8 is still supported in general.
Known consumers are on py3.9+ at this point, and we otherwise have enough changes on master to warrant a minor release (including dropping py3.7).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem statement
In #471, we have hit issues running wrapanapi unit tests with Python 3.8. Errors related to
typinglibrary were showing up.Solution
Unit tests using Python 3.9 do not throw any error, therefore we can drop Python 3.8.
After talking to @mshriver, we should be good to drop Python 3.8 since all known wrapanapi users are using 3.9+.