Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doing coverage checks on Ubuntu 22.04 instead of latest due to autoconf lcov >= 2.0 issue #293

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented Jan 13, 2025

CI on memtier is failing reference failure but due to ubuntu 24.04 support (they should have changed ubuntu:latest to it).
Related to lcov >= 2.0 version check. To fix it we should do coverage checks on Ubuntu 22.04 instead of latest.
On 24.04 we have:

Get:42 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 lcov all 2.0-4ubuntu2 [223 kB]

and we want:

checking for lcov version... invalid
configure: error: You must have one of the following versions of lcov: 1.6 1.7 1.8 1.9 1.10 1.11 1.12 1.13 1.14 1.15 1.16 (found: /etc/lcovrc).
Error: Process completed with exit code 1.

reference happening to others:
autoconf-archive/autoconf-archive#298 (comment)

After my github-actions runner was updated to ubuntu 24.04.1 (latest) it received new version of lcov.
This also broke my CI/CD workflow. I hope maintainers will address this issue!
For now I will downgrade my runner to ubuntu 22.04.

@filipecosta90 filipecosta90 merged commit ae4c12b into RedisLabs:master Jan 13, 2025
7 checks passed
@filipecosta90 filipecosta90 deleted the lcov.fix branch January 13, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants