Revert LATENCY_HDR_SEC_SIGDIGTS to 2. Optimize summarize_current_second by using hdr_value_at_percentiles() instead of N x hdr_value_at_percentile(). #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd by using hdr_value_at_percentiles() instead of N x hdr_value_at_percentile().
YaacovHazan
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294
It also updates the hdr histogram dependency to make usage of 2 optimizations we've added there quite a while ago:
highest_equivalent_value/lowest_equivalent_value/hdr_median_equivalent_valuecalls onhdr_next_non_equivalent_valueHdrHistogram/HdrHistogram_c#94Altogether, we've reverted the regression introduced in v2.1.1 and also reduced by 22% the CPU usage for the same QPS (even a bit higher).
Sample benchmark command:
CPU usage fix and improvement (red is this PR) :
Ops/sec fix and improvement (red is this PR) :