-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redis-cli TLS connections #2635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
But I think it should also be reviewed and approved by those who maintain redis-cli.
I suggest to ask @oranagra to take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've never connected with redis-cli to RE using TLS, so i can't comment on most of that text.
i suggest asking a proxy developer or QA person that tested it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One wording suggestion
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Received a review from Oran, and Kurt has also taken a look at the TLS connection section and provided feedback.
* redis-cli TLS connections * Apply suggestions from code review Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com> * Feedback updates --------- Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Staged preview