Skip to content

Document that auto-exposure won't work on Mobile & Compatibility.#1209

Merged
Arctis-Fireblight merged 1 commit intoRedot-Engine:masterfrom
AR-DEV-1:autoexposure-docs
Mar 8, 2026
Merged

Document that auto-exposure won't work on Mobile & Compatibility.#1209
Arctis-Fireblight merged 1 commit intoRedot-Engine:masterfrom
AR-DEV-1:autoexposure-docs

Conversation

@AR-DEV-1
Copy link
Contributor

@AR-DEV-1 AR-DEV-1 commented Mar 4, 2026

TL;DR

  • Godot counterpart: Document that auto-exposure won't work on Mobile & Compatibility. godotengine/godot#114712
  • Document that auto-exposure won't work on Mobile & Compatibility in CameraAttributes, CameraAttributesPractical & CameraAtrributesPhysical.
  • Also, in CameraAttributesPractical, added a note which tells that depth of field only works on Forward+ & Mobile following the same note in CameraAtrributesPhysical.
  • Small enhancement in the rendering documentation

Note

Contributed by 2LazyDevs.

Summary by CodeRabbit

  • Documentation
    • Clarified rendering method compatibility for auto-exposure feature: supported in Forward+ only, not in Mobile or Compatibility methods.
    • Clarified rendering method compatibility for depth-of-field blur: supported in Forward+ and Mobile, not in Compatibility method.

@coderabbitai
Copy link

coderabbitai bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: eb6d0c6f-bf2e-4365-befd-bd0a7ac24003

📥 Commits

Reviewing files that changed from the base of the PR and between 3ef8058 and 859a269.

📒 Files selected for processing (3)
  • doc/classes/CameraAttributes.xml
  • doc/classes/CameraAttributesPhysical.xml
  • doc/classes/CameraAttributesPractical.xml

Walkthrough

Documentation updates to three camera attribute classes, adding explanatory notes clarifying feature availability across different rendering methods (Forward+, Mobile, and Compatibility rendering pipelines).

Changes

Cohort / File(s) Summary
Camera Attributes Documentation
doc/classes/CameraAttributes.xml, doc/classes/CameraAttributesPhysical.xml, doc/classes/CameraAttributesPractical.xml
Added notes documenting auto-exposure and depth-of-field feature support limitations across rendering methods. Auto-exposure supported only in Forward+ rendering; DOF blur supported in Forward+ and Mobile only.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately reflects the main change: adding documentation about auto-exposure limitations on Mobile & Compatibility rendering modes across three XML documentation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@Arctis-Fireblight Arctis-Fireblight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Arctis-Fireblight Arctis-Fireblight merged commit 2882fe1 into Redot-Engine:master Mar 8, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants