GH-1226 Have Wayland chosen as default if user is using it#1227
GH-1226 Have Wayland chosen as default if user is using it#1227JoltedJon wants to merge 1 commit intoRedot-Engine:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds logic to auto-select Wayland as the display driver when "default" is specified and the WAYLAND_DISPLAY environment variable is set, preventing fallback to X11 on Wayland systems. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AR-DEV-1
left a comment
There was a problem hiding this comment.
Small fix, LGTM. Better to use Wayland where X11 doesn't have good support or Wayland is being used by default.
|
I am going to go ahead and mark this as a draft. We touched on these subjects on Discord, but I wanted to kinda recap my concerns for public record. Wayland support is still marked as experimental in Godot. It seems there has been good progress on fixing issues, support for some Desktop Environments lag behind others, most notably GNOME. We may want to consider adding additional logic to detect the user's DE and default to XWayland in cases where the we know the Wayland implementation doesnt play nice with their DE or Distro. |
Fixes #1226 Current Design of Godot has it so that you have to explicitly set Wayland as the chosen display driver in project settings or via the command line. This change will automatically have Wayland chosen if detected and the display driver is set to the default driver. Essentially making the default chosen option the display server that the user is using instead of X11.
This may have some consequences since there are mentions of wayland features not being entirely complete, but that is something we can work towards. godotengine/godot#88346
Summary by CodeRabbit