Clean up warnings and set the correct visibility on classes and inter…

…faces
RedpointArchive · Mar 19, 2016 · e2ccef6 · e2ccef6
1 parent 13cf409
commit e2ccef6
Show file tree

Hide file tree

Showing 228 changed files with 614 additions and 322 deletions.
diff --git a/Build/Projects/Protobuild.FunctionalTests.definition b/Build/Projects/Protobuild.FunctionalTests.definition
@@ -1,5 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project Name="Protobuild.FunctionalTests" Path="Protobuild.FunctionalTests" Type="Console">
+  <Properties>
+    <Property Name="NoWarn" Value="1591" />
+  </Properties>
   <References>
     <Reference Include="System" />
     <Reference Include="System.Core" />

diff --git a/Build/Projects/Protobuild.UnitTests.definition b/Build/Projects/Protobuild.UnitTests.definition
@@ -1,5 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project Name="Protobuild.UnitTests" Path="Protobuild.UnitTests" Type="Console">
+  <Properties>
+    <Property Name="NoWarn" Value="1591" />
+  </Properties>
   <References>
     <Reference Include="System" />
     <Reference Include="System.Core" />

diff --git a/Protobuild.Compress/Program.cs b/Protobuild.Compress/Program.cs
@@ -4,8 +4,16 @@
 
 namespace Protobuild.Compress
 {
+    /// <summary>
+    /// A program which compresses files so they can be embedded inside the single
+    /// Protobuild executable that is produced.
+    /// </summary>
     public static class Program
     {
+        /// <summary>
+        /// The main entry point for the compression utility.
+        /// </summary>
+        /// <param name="args">The arguments passed in on the command line.</param>
         public static void Main(string[] args)
         {
             if (args.Length == 0)

diff --git a/Protobuild.Debug/Program.cs b/Protobuild.Debug/Program.cs
@@ -2,8 +2,15 @@
 
 namespace Protobuild.Bootstrap
 {
+    /// <summary>
+    /// The debug version of the bootstrapping program.
+    /// </summary>
     public static class Program
     {
+        /// <summary>
+        /// The entry point for the bootstrapping program.
+        /// </summary>
+        /// <param name="args">The arguments passed in on the command line.</param>
         public static void Main(string[] args)
         {
             // This is an alternative version of the standard Protobuild.exe

diff --git a/Protobuild.FunctionalTests/ProtobuildTest.cs b/Protobuild.FunctionalTests/ProtobuildTest.cs
@@ -179,8 +179,6 @@ protected string GetPath(string path)
 
         protected Dictionary<string, byte[]> LoadPackage(string path)
         {
-            var results = new Dictionary<string, byte[]>();
-
             if (path.EndsWith(".tar.lzma"))
             {
                 using (var lzma = new FileStream(Path.Combine(m_TestLocation, path), FileMode.Open, FileAccess.Read, FileShare.None))
@@ -212,8 +210,6 @@ protected Dictionary<string, byte[]> LoadPackage(string path)
             {
                 throw new NotSupportedException();
             }
-
-            return results;
         }
 
         protected string SetupSrcPackage()

diff --git a/Protobuild.Internal/AutomatedBuild/AutomatedBuildController.cs b/Protobuild.Internal/AutomatedBuild/AutomatedBuildController.cs
@@ -3,7 +3,7 @@
 
 namespace Protobuild
 {
-    public class AutomatedBuildController : IAutomatedBuildController
+    internal class AutomatedBuildController : IAutomatedBuildController
     {
         private readonly IAutomatedBuildRuntimeV1 _automatedBuildRuntimeV1;
 

diff --git a/Protobuild.Internal/AutomatedBuild/AutomatedBuildRuntimeV1.cs b/Protobuild.Internal/AutomatedBuild/AutomatedBuildRuntimeV1.cs
@@ -8,7 +8,7 @@
 
 namespace Protobuild
 {
-    public class AutomatedBuildRuntimeV1 : IAutomatedBuildRuntimeV1
+    internal class AutomatedBuildRuntimeV1 : IAutomatedBuildRuntimeV1
     {
         private readonly IHostPlatformDetector _hostPlatformDetector;
         private readonly IWorkingDirectoryProvider _workingDirectoryProvider;

diff --git a/Protobuild.Internal/AutomatedBuild/IAutomatedBuildController.cs b/Protobuild.Internal/AutomatedBuild/IAutomatedBuildController.cs
@@ -1,6 +1,6 @@
 namespace Protobuild
 {
-    public interface IAutomatedBuildController
+    internal interface IAutomatedBuildController
     {
         int Execute(string path);
     }

diff --git a/Protobuild.Internal/AutomatedBuild/IAutomatedBuildRuntime.cs b/Protobuild.Internal/AutomatedBuild/IAutomatedBuildRuntime.cs
@@ -6,7 +6,7 @@
 
 namespace Protobuild
 {
-    public interface IAutomatedBuildRuntime
+    internal interface IAutomatedBuildRuntime
     {
         object Parse(string text);
         int Execute(object handle);

diff --git a/Protobuild.Internal/AutomatedBuild/IAutomatedBuildRuntimeV1.cs b/Protobuild.Internal/AutomatedBuild/IAutomatedBuildRuntimeV1.cs
@@ -1,6 +1,6 @@
 namespace Protobuild
 {
-    public interface IAutomatedBuildRuntimeV1 : IAutomatedBuildRuntime
+    internal interface IAutomatedBuildRuntimeV1 : IAutomatedBuildRuntime
     {
     }
 }