Use TextureView instead of SurfaceView on Android. #459

nielsenko · 2016-11-10T08:53:42Z

Compared to existing ZXingSurfaceView, ZXingTextureView fixes the following:

Ensure correct aspect ratio, no matter what the view size.
Use background handler for all camera manipulation.
Crop preview to match viewfinder, so that you only scan what you see.
Avoid byte[] marshalling between Java and .Net runtime (FastJavaByteArray).
Return buffer to java runtime with camera.AddCallbackBuffer.
Avoid traslating from YCrCb to Rgb and back to luminance data (FastJavaByteArrayYUVLuminanceSource)
Re-use buffers, to avoid memory pressure, when rotating.
Automatically request autofocus on devices that does not support continous auto focus mode.
Prefer continous mode
For Xamarin.Forms ZXingScannerView now uses ZXingTextureView in the renderer on Android.

Redth · 2016-11-15T21:11:59Z

This looks great!!! going to take a bit to review, but thanks so much for doing this work. Will post follow up questions yet i'm sure.

Redth · 2016-11-15T21:13:20Z

Source/ZXing.Net.Mobile.Android/CameraExtensions.cs

+using Android.Hardware;
+using Android.Runtime;
+
+namespace ApxLabs.FastAndroidCamera


Could you please change the namespace here?

The reason I kept the APXLabs namespace in:

CameraExtensions.cs FastJavaByteArray.cs FastJavaByteArrayEnumerator.cs

is that these files stems from: https://github.com/APXLabs/FastAndroidCamera. APXLabs is not my company, and even if the license permits me to change the namespace I felt it was a bit rude.

I only modified the files to use the JniEnvironment class (introduced with Xamarin.Android 6.1, if I recall correctly)

However I see that James Athey (the original author - https://github.com/jamesathey) has done some simlar fixes this september, and even released a nuget: https://www.nuget.org/packages/FastAndroidCamera/ Perhaps it would be better to reference this, what do you think?

Redth · 2016-11-15T21:31:49Z

As part of this, I think this has swayed me enough to completely drop support for < 4.0.3 (TextureView is only available on 4.0+).

nielsenko · 2016-11-16T10:03:31Z

Can't really grok what fails on the build servers..

f1nzer · 2016-11-16T11:32:32Z

Source/ZXing.Net.Mobile.Android/ZXing.Net.Mobile.Android.csproj

@@ -41,6 +42,9 @@
      <HintPath>..\..\packages\Xamarin.Android.Support.v4.23.3.0\lib\MonoAndroid403\Xamarin.Android.Support.v4.dll</HintPath>
      <Private>True</Private>
    </Reference>
+    <Reference Include="FastAndroidCamera">
+      <HintPath>..\..\Samples\Forms\packages\FastAndroidCamera.2.0.0\lib\MonoAndroid403\FastAndroidCamera.dll</HintPath>


Change hint path from Samples folder to ..\..\packages\....

f1nzer · 2016-11-16T11:33:23Z

Source/ZXing.Net.Mobile.Forms.Android/ZXing.Net.Mobile.Forms.Android.csproj

@@ -94,6 +95,9 @@
      <HintPath>..\..\packages\Xamarin.Forms.2.3.0.107\lib\MonoAndroid10\Xamarin.Forms.Xaml.dll</HintPath>
      <Private>True</Private>
    </Reference>
+    <Reference Include="FastAndroidCamera">
+      <HintPath>..\..\Samples\Forms\packages\FastAndroidCamera.2.0.0\lib\MonoAndroid403\FastAndroidCamera.dll</HintPath>


Redth · 2016-11-16T12:56:41Z

Ahh I didn't realize this wasn't your code. Definitely in that case I wouldn't want to remove the namespace but I like the switch to a nuget dependency anyway.

Redth · 2016-11-16T21:26:19Z

I'm going to take a shot at manually merging this tomorrow since I've just merged a big refactor of these related classes into master. Thanks for doing this work!

Also, you inspired me to do the same type of work for iOS which saw some huge performance gains from the work I did on it this morning.

Cheers!

nielsenko · 2016-11-17T08:20:23Z

Sounds great. I will merge with master for you. Looking forward for your changes on the iOS side!

nielsenko · 2016-11-17T09:41:38Z

All systems are go!

nielsenko · 2016-11-22T12:27:11Z

@Redth, don't hesitate to contact me, if you have any questions/comments

Redth · 2016-11-22T16:57:13Z

Thanks, I'm going to bring in the changes to ZXingSurfaceView first. We'll have to revisit some of the refactoring @f1nzer did around the android camera (it's coupled to SurfaceView) so that we can follow the same pattern with the TextureView implementation.

nielsenko · 2016-11-30T11:23:25Z

Hi @Redth,
Could you share the status on this? Perhaps I can help out?

adusak · 2017-03-27T13:23:39Z

Any news regarding this pull request? It is extensive fixes alot of issues, it would be a shame for it to go to waste.

nielsenko · 2017-03-27T13:34:51Z

No; I haven't heard more from @Redth. I think he is busy with other stuff. I have created nugets for Android here: https://www.myget.org/F/custom-zxing-mobile/. I wasn't sure what to do with the version number, so it has the odd version 2.1.11 where 2.1 is taken from the original source, and 11 is my bitrise build number.

Redth · 2017-04-12T19:23:16Z

@nielsenko sorry i dropped the ball on this one. I've finally got some of the android fast camera stuff into master and released.

If you are open to it, I'd love this to be rebased on current master. If you're not able to get to that, I can always have a look...

nielsenko · 2017-04-20T08:19:59Z

I'm a bit pressed for time right now, but I will give it a try, once I get around to it.

…n FastJavaByteArrayYUVLuminanceSource and simplify CameraAnalyzer

Compared to existing ZXingSurfaceView, ZXingTextureView fixes the following: - Ensure correct aspect ratio, no matter what the view size. - Use background handler for all camera manipulation. - Crop preview to match viewfinder, so that you only scan what you see. - Avoid byte[] marshalling between Java and .Net runtime (FastJavaByteArray). - Return buffer to java runtime with camera.AddCallbackBuffer. - Avoid traslating from YCrCb to Rgb and back to luminance data (FastJavaByteArrayYUVLuminanceSource) - Re-use buffers, to avoid memory pressure, when rotating. - Automatically request autofocus on devices that does not support continous auto focus mode. - Prefer continous mode - For Xamarin.Forms ZXingScannerView now uses ZXingTextureView in the renderer on Android.

…d a FastJavaArrayEx.BlockCopyTo method to compensate for missing funtionality.

…ep a ringbuffer of recent barcodes, and honor DelayBetweenContinuousScans (of same barcode)

rstcrypto · 2018-01-18T17:17:53Z

any update on this?

GiampaoloGabba · 2018-12-27T22:18:02Z

I suppose we will never get this merged :(
Maybe after the new dev branch will be released, i will fork everything and try to rebase & merge this pull request. Its very promising and i think it can improve a lot this beautiful project

Softtinn · 2020-05-08T16:33:45Z

What's the hold up on this?
It's a great fix! A shame if all the work from the author goes to waste...

nielsenko · 2020-05-09T15:43:03Z

@Softtinn My PR was an offshoot from a contract back in 2016 for a scandinavian postal service. I'm no longer involved with this project, so my personal interest has faded. I think @Redth was just busy with other stuff, and hence it never got merged. I'm not sure how many of these improvements has made it into master through other PRs. There has been quite a lot of releases since then. Today, I would probably use Google Vision instead (https://developers.google.com/vision/android/barcodes-overview) and Camera X (https://developer.android.com/training/camerax)

Redth · 2020-05-09T15:44:38Z

I do plan on incorporating this in the future. Right now I’m too tied up with other pandemic related work so it may be a few weeks before I get back to this project yet.

Redth reviewed Nov 15, 2016

View reviewed changes

f1nzer reviewed Nov 16, 2016

View reviewed changes

hmoratopcs mentioned this pull request Nov 21, 2016

Slow camera view within tabs #469

Closed

nielsenko added 8 commits May 23, 2017 10:19

Add RotateInPlace method to FastJavaArrayEx, avoid code duplication i…

d61ed46

…n FastJavaByteArrayYUVLuminanceSource and simplify CameraAnalyzer

Reference FastAndroidCamera nuget instead of maintaining own copy. Ad…

7c2accd

…d a FastJavaArrayEx.BlockCopyTo method to compensate for missing funtionality.

Updated .nuspecs to reference FastAndroidCamera nuget

c565bff

Bitten by a bad HintPath.. Doh!

94fb818

Fix: NRE in SetSurfaceTransform, if called before camera is ready. Ke…

52c64c2

…ep a ringbuffer of recent barcodes, and honor DelayBetweenContinuousScans (of same barcode)

Guard against ObjectDisposedException in Post call

6ce1729

Fixes to ZXing[Texture|Surface]View after merge of PR Redth#533

7d60a20

nielsenko force-pushed the android-textureview branch from f857bfe to 7d60a20 Compare May 31, 2017 02:32

nielsenko added 3 commits May 31, 2017 05:26

Move try-catch on OnOrientationChanged to MyOrientationListener

3a2e901

Reorder Dispose on ZXingTextureView

abff866

Honor DelayBetweenAnalyzingFrames & DelayBetweenContinuousScans

454551b

Update XF to latest stable (2.3.4)

dda2ff2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use TextureView instead of SurfaceView on Android. #459

Use TextureView instead of SurfaceView on Android. #459

nielsenko commented Nov 10, 2016

Redth commented Nov 15, 2016

Redth Nov 15, 2016

nielsenko Nov 16, 2016

Redth commented Nov 15, 2016

nielsenko commented Nov 16, 2016

f1nzer Nov 16, 2016 •

edited

Loading

f1nzer Nov 16, 2016

Redth commented Nov 16, 2016

Redth commented Nov 16, 2016

nielsenko commented Nov 17, 2016 •

edited

Loading

nielsenko commented Nov 17, 2016

nielsenko commented Nov 22, 2016

Redth commented Nov 22, 2016

nielsenko commented Nov 30, 2016 •

edited

Loading

adusak commented Mar 27, 2017

nielsenko commented Mar 27, 2017

Redth commented Apr 12, 2017

nielsenko commented Apr 20, 2017

rstcrypto commented Jan 18, 2018

GiampaoloGabba commented Dec 27, 2018

Softtinn commented May 8, 2020

nielsenko commented May 9, 2020

Redth commented May 9, 2020

Use TextureView instead of SurfaceView on Android. #459

Are you sure you want to change the base?

Use TextureView instead of SurfaceView on Android. #459

Conversation

nielsenko commented Nov 10, 2016

Redth commented Nov 15, 2016

Redth Nov 15, 2016

Choose a reason for hiding this comment

nielsenko Nov 16, 2016

Choose a reason for hiding this comment

Redth commented Nov 15, 2016

nielsenko commented Nov 16, 2016

f1nzer Nov 16, 2016 • edited Loading

Choose a reason for hiding this comment

f1nzer Nov 16, 2016

Choose a reason for hiding this comment

Redth commented Nov 16, 2016

Redth commented Nov 16, 2016

nielsenko commented Nov 17, 2016 • edited Loading

nielsenko commented Nov 17, 2016

nielsenko commented Nov 22, 2016

Redth commented Nov 22, 2016

nielsenko commented Nov 30, 2016 • edited Loading

adusak commented Mar 27, 2017

nielsenko commented Mar 27, 2017

Redth commented Apr 12, 2017

nielsenko commented Apr 20, 2017

rstcrypto commented Jan 18, 2018

GiampaoloGabba commented Dec 27, 2018

Softtinn commented May 8, 2020

nielsenko commented May 9, 2020

Redth commented May 9, 2020

f1nzer Nov 16, 2016 •

edited

Loading

nielsenko commented Nov 17, 2016 •

edited

Loading

nielsenko commented Nov 30, 2016 •

edited

Loading