Fix pre-commit version incompatibility with Python 3.8-3.9 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: omsherikar <180152315+omsherikar@users.noreply.github.com>
Co-authored-by: omsherikar <180152315+omsherikar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix quick setup problem in application
Fix pre-commit version incompatibility with Python 3.8-3.9
Dec 28, 2025
github-actions
bot
added
dependencies
size: small
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Python version compatibility issue where pre-commit==4.5.1 (which requires Python >=3.10) was causing CI failures on Python 3.8 and 3.9 environments.
- Downgraded pre-commit from 4.5.1 to 4.3.0 to support Python 3.8+
- Added
*.whlpattern to .gitignore
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements-dev.txt | Downgraded pre-commit version from 4.5.1 to 4.3.0 to restore compatibility with Python 3.8 and 3.9 |
| .gitignore | Added *.whl pattern to ignore wheel files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI was failing on Python 3.8 and 3.9 because
pre-commit==4.5.1requires Python >=3.10.Changes
pre-commitfrom 4.5.1 to 4.3.0 inrequirements-dev.txt(last version supporting Python 3.8+)*.whlto.gitignoreto prevent wheel files from being committedThe project supports Python 3.8-3.12 per
pyproject.toml, but the pinned pre-commit version was incompatible with the lower bounds. Version 4.3.0 maintains the same functionality while supporting the full Python version range tested in CI.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.