Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 30, 2025

CI was failing on Python 3.8 and 3.9 because pre-commit==4.5.1 requires Python ≥3.10.

Changes

  • Updated requirements-dev.txt to use pre-commit>=3.5.0,<4.0.0 instead of pinning to 4.5.1
  • This constraint ensures compatibility with Python 3.8+ while still getting recent pre-commit versions

Context

The error from CI:

ERROR: Ignored the following versions that require a different python version: 
  4.4.0 Requires-Python >=3.10; 4.5.0 Requires-Python >=3.10; 4.5.1 Requires-Python >=3.10
ERROR: Could not find a version that satisfies the requirement pre-commit==4.5.1

Pre-commit 3.x supports Python 3.8+, while 4.x requires Python 3.10+. The version constraint now allows installation on all supported Python versions in the test matrix.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Dec 30, 2025
Copilot AI mentioned this pull request Dec 30, 2025
54 tasks
@coderabbitai
Copy link

coderabbitai bot commented Dec 30, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: omsherikar <180152315+omsherikar@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix quick setup issues in the application Fix pre-commit version constraint for Python 3.8-3.9 compatibility Dec 30, 2025
Copilot AI requested a review from omsherikar December 30, 2025 12:59
@omsherikar omsherikar marked this pull request as ready for review December 30, 2025 13:19
Copilot AI review requested due to automatic review settings December 30, 2025 13:19
@omsherikar omsherikar merged commit b8042d2 into feat/quick-setup Dec 30, 2025
13 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a CI failure on Python 3.8 and 3.9 by updating the pre-commit version constraint to be compatible with older Python versions. Pre-commit 4.x requires Python ≥3.10, while version 3.x supports Python 3.8+.

  • Changed pre-commit constraint from a pinned version to a range that supports Python 3.8-3.9
  • Ensures compatibility with all Python versions in the CI test matrix (3.8-3.12)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

flake8>=6.0.0
isort>=5.12.0
pre-commit==4.3.0
pre-commit>=3.5.0,<4.0.0
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions an error related to pre-commit==4.5.1, but the actual change in the diff shows the previous version was pre-commit==4.3.0. The description should be updated to reflect the actual version being changed from (4.3.0) rather than 4.5.1, or clarify if there was an intermediate change.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants