Removed Python <3.3 mock imports from unit-test files #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be happy if I make a release without these unnecessary changes? 😄 |
|
First: 😆 Secondly, I think it's not unnecessary. Having exceptions for stuff that's been gone for ages obscurifies the code and makes it harder to read and understand. Won't you agree? |
|
OK. You're right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lociii
in order to get my new release, I have to fix more stuff, right? 😆
Here's a tiny fix for Python <3.3 compat, which we don't support anymore.
Best from Cologne
Ronny