fix

pallets/regions/src/lib.rs

@@ -418,6 +418,7 @@ impl<T: Config> Default for IsmpModuleCallback<T> {
 	}
 }
 
+use frame_support::ensure;
 impl<T: Config> IsmpModule for IsmpModuleCallback<T> {
 	fn on_accept(&self, _request: Post) -> Result<(), IsmpError> {
 		Err(IsmpCustomError::NotSupported.into())

pallets/regions/src/tests.rs

@@ -18,7 +18,7 @@ use crate::{
 	Error, Event, IsmpCustomError, IsmpModuleCallback, Record, Region,
 };
 use frame_support::{
-	assert_err, assert_noop, assert_ok,
+	assert_noop, assert_ok,
 	pallet_prelude::*,
 	traits::nonfungible::{Inspect, Mutate, Transfer as NonFungibleTransfer},
 };
@@ -286,19 +286,15 @@ fn on_timeout_works() {
 
 		// failed to decode region_id
 		let mut invalid_get_req = get.clone();
-		invalid_get_req.keys.push(vec![0u8; 15]);
-		assert_err!(
+		invalid_get_req.keys = vec![vec![0u8; 15]];
+		assert_noop!(
 			module.on_timeout(Timeout::Request(Request::Get(invalid_get_req.clone()))),
 			IsmpCustomError::KeyDecodeFailed
 		);
 
 		// invalid id: region not found
-		invalid_get_req.keys.pop();
-		if let Some(key) = invalid_get_req.keys.get_mut(0) {
-			for i in 0..key.len() {
-				key[i] = key[i].reverse_bits();
-			}
-		}
+		let non_existing_region = RegionId { begin: 42, core: 72, mask: CoreMask::complete() };
+		invalid_get_req.keys = vec![non_existing_region.encode()];
 		assert_noop!(
 			module.on_timeout(Timeout::Request(Request::Get(invalid_get_req.clone()))),
 			IsmpCustomError::RegionNotFound
@@ -314,6 +310,7 @@ fn on_timeout_works() {
 			data: Default::default(),
 		};
 		assert_ok!(module.on_timeout(Timeout::Request(Request::Post(post.clone()))));
+		System::assert_last_event(Event::RequestTimedOut { region_id }.into());
 
 		assert_ok!(module.on_timeout(Timeout::Response(PostResponse {
 			post,