Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow improvements #81

Merged
merged 23 commits into from
Apr 17, 2024
Merged

CI workflow improvements #81

merged 23 commits into from
Apr 17, 2024

Conversation

Szegoo
Copy link
Member

@Szegoo Szegoo commented Apr 16, 2024

  • Build the regionx-node to run a smoke test instead of pulling the latest image from Docker. This ensures that the code we test against is the one from the branch.
  • Cancel ongoing workflows when new ones are triggered
  • Code coverage

@Szegoo Szegoo mentioned this pull request Apr 16, 2024
3 tasks
@Szegoo Szegoo requested a review from cuteolaf April 16, 2024 20:54
Copy link
Member

@cuteolaf cuteolaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but code coverage doesn't seem working.

Copy link

codecov bot commented Apr 17, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@Szegoo
Copy link
Member Author

Szegoo commented Apr 17, 2024

looks good, but code coverage doesn't seem working.

I had to add the codecov secret. now it is working.

@Szegoo Szegoo merged commit d6313a1 into main Apr 17, 2024
6 checks passed
@cuteolaf cuteolaf deleted the ci-improvements branch April 17, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants