Skip to content

bug/AB#95015 - Browser freezes on dropdowns with too much options #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: 2.x.x
Choose a base branch
from
Draft

bug/AB#95015 - Browser freezes on dropdowns with too much options #2603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3190021
Started trying to implement cdk virtual scrolling
brunotannus Jun 6, 2024
a85b5ee
Merge branch '2.x.x' into bug/AB#95015_browser-freezes-on-large-dropd…
AntoineRelief Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions libs/shared/src/lib/components/filter/filter-row/filter-row.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,19 @@
<ui-select-option>{{
'common.input.none' | translate
}}</ui-select-option>
<ui-select-option
*ngFor="let option of field.options"
[value]="option.value"
<cdk-virtual-scroll-viewport
itemSize="30"
class="virtual-scroll-viewport"
>
{{ option.text }}
</ui-select-option>
<ui-select-option
*cdkVirtualFor="let option of field.options"
[value]="option.value"
>
{{ option.text }}
</ui-select-option>
</cdk-virtual-scroll-viewport>
</ui-select-menu>

<ui-select-menu
[filterable]="true"
*ngIf="field.multiSelect"
Expand All @@ -154,12 +160,17 @@
<ui-select-option>{{
'common.input.none' | translate
}}</ui-select-option>
<ui-select-option
*ngFor="let option of field.options"
[value]="option.value"
<cdk-virtual-scroll-viewport
itemSize="30"
class="virtual-scroll-viewport"
>
{{ option.text }}
</ui-select-option>
<ui-select-option
*cdkVirtualFor="let option of field.options"
[value]="option.value"
>
{{ option.text }}
</ui-select-option>
</cdk-virtual-scroll-viewport>
</ui-select-menu>
</div>
</ng-template>
Expand Down
6 changes: 6 additions & 0 deletions libs/shared/src/lib/components/filter/filter-row/filter-row.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,9 @@
gap: 8px;
}
}

.virtual-scroll-viewport {
height: 200px; /* Adjust height as needed */
overflow: hidden;
display: block;
}
2 changes: 2 additions & 0 deletions libs/shared/src/lib/components/filter/filter.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
DateModule,
TooltipModule,
} from '@oort-front/ui';
import { ScrollingModule } from '@angular/cdk/scrolling';

/**
* Composite Filter module.
Expand All @@ -29,6 +30,7 @@ import {
DateModule,
FormWrapperModule,
TooltipModule,
ScrollingModule,
],
exports: [FilterComponent],
})
Expand Down