Preserve exclusion/include list and add Progress bar for local mod installation #667
Conversation
…yPackagesFromExtractFolderToTargetDir async to stop UI freezes for larger mods.
TheBestAstroNOT
changed the title
…Wrapper was modified The config used to only be updated once an item was added or deleted.
|
Also fixed a bug where adding |
Makes it so they don't come back everytime you open the publish window if you remove them (though I have no idea why anyone would remove these regexes)
| /// <summary> | ||
| /// ViewModel for downloading an individual package. | ||
| /// </summary> | ||
| public class InstallPackageViewModel : INotifyPropertyChanged |
There was a problem hiding this comment.
You should use autogeneration for INotifyPropertyChanged here.
It's been a while since I've worked on R2 but I believe this uses Fody.PropertyChanged.
There was a problem hiding this comment.
This is not the way the rest of the project does this IIRC. Have a quick peek around.
|
|
||
| // Set default Regexes. | ||
| IgnoreRegexes = new ObservableCollection<StringWrapper>() | ||
| IgnoreRegexes = new ObservableCollection<StringWrapper>( |
There was a problem hiding this comment.
Is this not overkill?
You can just save it when the menu is closed.
There was a problem hiding this comment.
It might also save you from unnecessarily implementing PropertyChanged in the other place.
There was a problem hiding this comment.
I think this still needs moving.
Sorry for the bad commit names, it's a bit late for me rn
|
I will clean this up later- god knows when, but later- still a bit of unneeded AI junk remaining. |
3 participants
No description provided.