Skip to content

Commit

Permalink
[coverity] Fixing some coverity warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
sherholz-intel committed Sep 19, 2024
1 parent eb01b60 commit f82b680
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
3 changes: 3 additions & 0 deletions openpgl/data/SampleContainerInternal.h
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ struct ContainerInternal
using value_type = Type;

ContainerInternal() = default;

ContainerInternal(const ContainerInternal& cont) = delete;

~ContainerInternal()
{
delete[] m_data;
Expand Down
4 changes: 4 additions & 0 deletions openpgl/imagespace/Denoiser.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ struct Denoiser
oidnScalarFilter.commit();
}

Denoiser(const Denoiser& denoiser) = delete;

Denoiser & operator=(const Denoiser&) = delete;

void denoise(pgl_vec3f *rgb, pgl_vec3f *n, pgl_vec3f *albedo, pgl_vec3f *result)
{
const std::size_t numPixels = m_resolution.x * m_resolution.y;
Expand Down
10 changes: 9 additions & 1 deletion openpgl/imagespace/ImageSpaceGuidingBuffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ struct ImageSpaceGuidingBuffer
filteredSecondMoment = new pgl_vec3f[numPixels];
}

Buffers(const Buffers& buffer) = delete;

Buffers & operator=(const Buffers&) = delete;

~Buffers()
{
delete[] contribution;
Expand Down Expand Up @@ -101,6 +105,10 @@ struct ImageSpaceGuidingBuffer
m_ready = false;
}

ImageSpaceGuidingBuffer(const ImageSpaceGuidingBuffer& isgbuffer) = delete;

ImageSpaceGuidingBuffer & operator=(const ImageSpaceGuidingBuffer&) = delete;

ImageSpaceGuidingBuffer(const std::string &fileName)
{
EXRVersion exrVersion;
Expand Down Expand Up @@ -484,7 +492,7 @@ struct ImageSpaceGuidingBuffer
private:
bool m_ready{false};
bool m_useSecondMoment{false};
pgl_point2i m_resolution;
pgl_point2i m_resolution {0, 0};
Denoiser *m_denoiser{nullptr};

Buffers *m_contributionEstimateBuffers{nullptr};
Expand Down

0 comments on commit f82b680

Please sign in to comment.