Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN-7483] Referer - Dashboard - Allow to filter profiles by refererId #236

Merged

Conversation

guillobits
Copy link
Contributor

No description provided.

@guillobits guillobits requested a review from DDZBX November 19, 2024 14:29
@guillobits guillobits self-assigned this Nov 19, 2024
@guillobits guillobits temporarily deployed to entourage-job-back-test November 19, 2024 14:29 — with GitHub Actions Inactive
@guillobits guillobits changed the base branch from develop to epic/EN-7455_orienter_candidats November 19, 2024 14:29
@guillobits guillobits changed the base branch from epic/EN-7455_orienter_candidats to feat/EN-7598-Referer-Refer-Candidate November 19, 2024 14:29
Copy link
Collaborator

@DDZBX DDZBX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guillobits guillobits temporarily deployed to entourage-job-back-test November 19, 2024 16:52 — with GitHub Actions Inactive
@guillobits guillobits requested a review from DDZBX November 25, 2024 13:24
@guillobits
Copy link
Contributor Author

guillobits commented Nov 25, 2024

Je te re-request une review étant donné que j'ai rechangé comme on s'est dit la semaine dernière.
En fait il est préférable de gérer cette affichage particulier dans une route spécifique. De cette manière la route est authentifiée POUR les referer uniquement et il ne peuvent récupérer que leurs propres referedCandidates et non pas tous les autres. J'ai gardé les mêmes informations que pour le get du réseau d'entraide si jamais on veut l'utiliser dans ce contexte plus tard.

Base automatically changed from feat/EN-7598-Referer-Refer-Candidate to epic/EN-7455_orienter_candidats November 27, 2024 15:19
Copy link
Collaborator

@DDZBX DDZBX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouep bon changement

Comment on lines +241 to +257
profiles.map(async (profile): Promise<PublicProfile> => {
const lastSentMessage = await this.getLastContact(
userId,
profile.user.id
);
const lastReceivedMessage = await this.getLastContact(
profile.user.id,
userId
);

const { user, ...restProfile }: UserProfile = profile.toJSON();
return {
...user,
...restProfile,
lastSentMessage: lastSentMessage?.createdAt || null,
lastReceivedMessage: lastReceivedMessage?.createdAt || null,
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas sur que ce soit opti si y a beaucoup de referredUsers mais on verra en temps voulu.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, j'ai simplement utilisé la même logique de construction que dans le réseau d'entraide mais c'est clairement perfectible.

@guillobits guillobits merged commit 41b3668 into epic/EN-7455_orienter_candidats Nov 27, 2024
2 checks passed
@guillobits guillobits deleted the feature/EN-7483-Referer-Dashboard branch November 27, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants