Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sns_ik_lib dependency on std_msgs #47

Open
IanTheEngineer opened this issue Apr 27, 2016 · 3 comments
Open

Remove sns_ik_lib dependency on std_msgs #47

IanTheEngineer opened this issue Apr 27, 2016 · 3 comments
Assignees

Comments

@IanTheEngineer
Copy link
Member

I was surprised to find that I added std_msgs as a dependency of sns_ik_lib. That seems wholly unnecessary, as evidenced by a quick search:
https://github.com/RethinkRobotics-opensource/sns_ik/search?utf8=%E2%9C%93&q=std_msgs

This dependency should be removed in the future.

@IanTheEngineer IanTheEngineer self-assigned this Apr 27, 2016
@rethink-forrest
Copy link

Once we remove ROS logging, we can probably also remove roscpp as a dependency.

@IanTheEngineer
Copy link
Member Author

Once we remove ROS logging, we can probably also remove roscpp as a dependency.

mmmmm nope. Not if we want to ever talk to the param server.

@rethink-forrest
Copy link

Ah, we do use NodeHandle in sns_ik.cpp to parse the urdf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant