Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the Matlab Implementation #85

Open
MatthewPeterKelly opened this issue Jun 18, 2018 · 1 comment
Open

Clean up the Matlab Implementation #85

MatthewPeterKelly opened this issue Jun 18, 2018 · 1 comment
Labels
good first issue If you are new to the project, then this is a great issue to work on. help wanted

Comments

@MatthewPeterKelly
Copy link
Contributor

The SNS-IK library has a Matlab implementation. At this point, the Matlab code is intended for debugging and for doing basic algorithm testing before implementing the production version in C++. There are several TODO markers in the code, especially related to input validation and clean return values for edge cases. It would be great if anyone wanted to read through and make this Matlab code into a more production-ready implementation.

In addition to small changes, this ticket could also include refactoring to reduce the overall code duplication.

@MatthewPeterKelly MatthewPeterKelly added help wanted good first issue If you are new to the project, then this is a great issue to work on. labels Jun 18, 2018
@robodreamer
Copy link

Sounds good. I can take on this after we finish the first iteration of getting all the core solvers pushed. We will probably need a document as well describing the algorithms in detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue If you are new to the project, then this is a great issue to work on. help wanted
Projects
None yet
Development

No branches or pull requests

2 participants