Skip to content

Conversation

@wescopeland
Copy link
Member

This PR adds support for game URLs with set parameters in the forum.

On submit, these are converted to [game={backingGameId}].

Screenshot 2025-10-29 at 6 30 44 PM

@wescopeland wescopeland requested a review from a team October 29, 2025 22:31
@wescopeland wescopeland requested a review from Jamiras November 6, 2025 22:15
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should editing a post convert the [game=subsetgameid] back into [game=gameid set=subsetid]?

@wescopeland
Copy link
Member Author

wescopeland commented Nov 10, 2025

I think we should obscure [game=X set=Y] as an implementation detail and instead reverse [game={backingGameId}] to route('game.show', ['game' => $game, 'set' => $set]. In other words, show the user the absolute URL when they go to edit the post.

This is sufficiently complicated enough that I'm going to merge this and tackle the reversal logic in a subsequent PR.

@wescopeland wescopeland merged commit ee37432 into RetroAchievements:master Nov 10, 2025
13 checks passed
@wescopeland wescopeland deleted the game-set-forum-shortcode branch November 10, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants