feat: bump react to 19.2.0, enforce rules of hooks #4118
+1,219
−959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps React and
eslint-plugin-react-hooksto latest and fixes numerous errors and warnings caused by these version updates. Most of the PR diff is lockfile noise, and there should be no functional changes as a result of this PR.React Compiler is an upcoming feature of React currently in beta that offers to dramatically improve render and hydration performance. It's not quite stable enough yet, but to confer its benefits, your components must strictly follow the rules of hooks as much as possible.
eslint-plugin-react-hookshas been updated to enforce the rules that React Compiler itself follows.I've gone through and fixed all the things it's complaining about, and left a "use no memo" directive on things that aren't fixable.