-
Notifications
You must be signed in to change notification settings - Fork 52
Move all external images to within the repo #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akleemans
wants to merge
23
commits into
RetroAchievements:main
Choose a base branch
from
akleemans:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+415
−415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Good question. It's possible VitePress changed something in a recent update. I think we should probably:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all images from external sources to this repository.
Solves the following issue: #158
Some notes:
camo.githubusercontent.comwere not accessible directly anymore, so I used the images provided by archive.org (Example)memsizes.png=>mem-inspector-size-diagram.png, images onmemory-inspector.md(memoryinspector-num.png,memoryinspector-filter.png,memoryinspector-bookmark.pngetc.)-), some underscores (_) were replaced.alttext to the images where missing, and tried to replace genericdescriptions with something more meaningful. I did not fix all existingalttexts, they are not all aligned currently, but I focussed on the image replacements.docs/guidelines/content/hash-labels.md(yet) - I was hesitant if those should be duplicated to this repo, as they are referenced directly (and used as image tags) from all the "Supported Game Files" pages. If they should also be included here please let me know. (I did update the image links in theptversion, there was an update to the image links in the English version which was not applied inpt).rabot-*.pngfor the Discord RA Bot page. If I get it correctly a flat directory structure ofpublicis desirable, so I didn't create subfolders.❓Question: When running the docs locally, I got warnings:
But the
contributing-to-the-docs.htmlexplicitly states to use image links with the/publicprefix:Can the local warnings be ignored?