Move rcbilling-demo to purchases-js
#32
Conversation
| @@ -0,0 +1,58 @@ | |||
| name: Test (rcbilling-demo) | |||
There was a problem hiding this comment.
This was brought over from the rcbilling-demo repo. I think we should unify CI systems but was running into some issues getting AWS commands to work in azure pipelines and wanted to get this merged earlier to avoid conflicts later. I just renamed the jobs so it's clear it refers to the billing demo for the tests/deploy. I'm planning to unify these systems later
| run: | | ||
| npm run build | ||
| env: | ||
| CI: true |
There was a problem hiding this comment.
I had to add these 2 commands first since now the demo app is pointing to the local version of purchases-js
| *.test.d.ts | ||
| examples/* |
There was a problem hiding this comment.
We don't want to include the rcbilling-demo app in the published package
| "prettier:ci": "prettier --check ." | ||
| }, | ||
| "dependencies": { | ||
| "@revenuecat/purchases-js": "file:../..", |
There was a problem hiding this comment.
Note that we are now pointing to the local version of the package.
|
|
||
| ### Development | ||
|
|
||
| - Install and build dependencies in the root `purchases-js` |
There was a problem hiding this comment.
I've updated these steps since now we need to make sure the library is built and updated before running the demo app.
tonidero
changed the title
rcbilling-demo to purchases-js
tonidero
force-pushed
the
move-rcbilling-demo-to-purchases-js
branch
from
7a0798a to
8d6fbe5
Compare
tonidero
force-pushed
the
move-rcbilling-demo-to-purchases-js
branch
from
8d6fbe5 to
1fe7b89
Compare
Co-authored-by: Franco Correa <4152942+francocorreasosa@users.noreply.github.com>
Motivation / Description
We wanted to unify the
rcbilling-demorepo intopurchases-js. This will help with development, since we can update usages of API changes within the same repo/PR and have tests using both together. Additionally, this will be helpful to write E2E tests.Note: This PR is based on #24 and the rcbilling-demo changes include the changes in https://github.com/RevenueCat/rcbilling-demo/pull/24 to try to avoid collisions.
Changes introduced
Linear ticket (if any)
Additional comments