-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI commands to dump and clone tag #201
base: main
Are you sure you want to change the base?
Conversation
Built artifacts for commit 8a02d6fFirmwareClient |
may i suggest the addition of another option, something like --plain, which then just exports in the good ol one key per line format? |
I can add the export option to my PR. But I think the .key and .dic format is better then custom format. because proxmark3 doesn't support custom format. |
I already add the export option in PR #199 I also change the option from |
ah, oki... With that one key per line i did mean .dic btw... |
# check ACL option | ||
if not args.clone_access: | ||
# if option is not specified, use generic ACL to be able to write again | ||
data = data[:6] + bytes.fromhex("08778F") + data[9:] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the acl ff0780
is better then the acl 08778F
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion, I've changed it to ff0780
.
So this PR is finished? |
You are the author of the export feature idea, so you can add a item to CHANGELOG.md after this PR is closed. |
You are welcome to add an entry to the CHANGELOG.md as well |
I merged From my point of view, ready to [be more tested and] merge. |
The dic file usually has comment lines. Maybe you can use the code: |
Note: based on PR #199
Thanks to @taichunmin implementation of
fchk
, this PR adds the following commands:hf mf dump
to dump the content of a tag from a dictionary of keys:Example:
hf mf clone
to clone the content of a dump to a tag:Example:
Note that by default, the
clone
command does not copy the ACL to avoid bricking the tag, but it could be enforced with--clone-access
.