Fix/ime position #494

wjian23 · 2023-12-04T07:46:01Z

No description provided.

codecov · 2023-12-04T07:56:00Z

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (9f8bef2) 85.45% compared to head (09d4042) 85.23%.
Report is 2 commits behind head on master.

❗ Current head 09d4042 differs from pull request most recent head 808276f. Consider uploading reports for the commit 808276f to get more accurate results

Files	Patch %	Lines
core/src/builtin_widgets/anchor.rs	67.56%	24 Missing ⚠️
widgets/src/input.rs	74.32%	19 Missing ⚠️
ribir/src/app.rs	0.00%	3 Missing ⚠️
themes/material/src/lib.rs	83.33%	2 Missing ⚠️
core/src/builtin_widgets.rs	96.55%	1 Missing ⚠️
core/src/widget_children/child_convert.rs	0.00%	1 Missing ⚠️
widgets/src/input/selected_text.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
- Coverage   85.45%   85.23%   -0.22%     
==========================================
  Files         177      178       +1     
  Lines       24378    24631     +253     
==========================================
+ Hits        20832    20995     +163     
- Misses       3546     3636      +90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/src/builtin_widgets.rs

widgets/src/input/selected_text.rs

widgets/src/input.rs

M-Adoo · 2023-12-19T02:44:47Z

core/src/builtin_widgets/anchor.rs

+  pub fn new(x: HAnchor, y: VAnchor) -> Self { Self { x: Some(x), y: Some(y) } }
+
+  /// Return Anchor that positions the widget's left top corner to the position
+  pub fn from_position(pos: Point) -> Self { Self::new(HAnchor::Left(pos.x), VAnchor::Top(pos.y)) }


from_point?

M-Adoo · 2023-12-19T02:50:24Z

core/src/builtin_widgets/anchor.rs

+    match (self, other) {
+      (HAnchor::Left(x1), HAnchor::Left(x2)) => HAnchor::Left(x1.lerp(x2, t)),
+      (HAnchor::Right(x1), HAnchor::Right(x2)) => HAnchor::Right(x1.lerp(x2, t)),
+      _ => unreachable!(),


Right None, None Left should implement Lerp, and should not panic when hit left <-->right

M-Adoo · 2023-12-19T02:56:48Z

core/src/builtin_widgets/global_anchor.rs

+      child
+        .widget_build(ctx!())


seems unnecessary attach

M-Adoo · 2023-12-19T03:00:51Z

core/src/builtin_widgets/global_anchor.rs

+  type Child = Widget;
+  #[inline]
+  fn compose_child(this: impl StateWriter<Value = Self>, child: Self::Child) -> impl WidgetBuilder {
+    fn eq(f1: Anchor, f2: Anchor) -> bool { f1.x == f2.x && f1.y == f2.y }


Does Anchor Derive PartialEq

M-Adoo · 2023-12-19T03:06:10Z

core/src/builtin_widgets.rs

+  pub fn lazy_host_id(&self) -> LazyWidgetId { self.builtin.lazy_host_id() }
+
+  /// Return the LazyWidgetId of the external widget (wrapped with the built-in
+  /// host), through which you can access the WidgetId after building.


/// Return the LazyWidgetId point to WidgetId of the root of the sub widget tree after the
/// FatObj has built.

core/src/builtin_widgets/global_anchor.rs

M-Adoo · 2023-12-19T03:54:11Z

core/src/builtin_widgets/global_anchor.rs

+impl<W> FatObj<W> {
+  /// Anchor the widget's horizontal position to the left edge of the widget
+  /// with WidgetId wid .
+  pub fn relative_to_left(


left_align_to ? and relative is a f32 not HAnchor

…re enter pre_ime state

…ttom) into anchor

wjian23 requested review from M-Adoo and sologeek December 4, 2023 07:46

wjian23 force-pushed the fix/ime_position branch from cf794ca to 6b32cca Compare December 4, 2023 07:51

wjian23 force-pushed the fix/ime_position branch 4 times, most recently from 750ddb3 to c1a169d Compare December 8, 2023 07:00