Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic aliases functionality #241

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rhopfer
Copy link
Contributor

@rhopfer rhopfer commented Aug 29, 2017

My proposal to add dynamic aliases (see #240). Please check the documentation I wrote because my english is bad. Suggestions are welcome.

@rhopfer rhopfer changed the title Feature aliases Add dynamic aliases functionality Aug 29, 2017
@alerque
Copy link
Collaborator

alerque commented Mar 31, 2021

Thanks for taking the time to contribute this yet. Overall the concept looks really interesting and I would even suggest that (if we go this route) the existing predefined aliases should be dropped in favor of a default alias config file that would be superseded by a user config if any. I have some concerns that the regex based approach to managing the content of the aliases file might be a bit complex and possibly brittle.

That being said before I review this too deeply or we make a decision I have to ask ... did you consider storing aliases in Git's config system? It's possible to set and retrieve arbitrary keys in there and since a working Git config is already an absolute requirement that might be a way to avoid the overhead of having a separate alias file handling system. Not that we're afraid of more dotfiles of course ;-)

@alerque
Copy link
Collaborator

alerque commented Apr 14, 2021

Just for reference, when reviewing this lets compare what GitHub did with their official CLI and its gh alias.

@RichiH
Copy link
Owner

RichiH commented Apr 14, 2021

Also Git's; I suspect everyone will know this, but just to make sure: https://git-scm.com/book/en/v2/Git-Basics-Git-Aliases

@alerque
Copy link
Collaborator

alerque commented May 29, 2021

Just in case it turns out useful later, it seems this PR's (currently only) commit is a squash of all the bits in this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants