Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No translation #1

Closed
18skeltor opened this issue Mar 23, 2024 · 18 comments
Closed

No translation #1

18skeltor opened this issue Mar 23, 2024 · 18 comments
Labels
help wanted Extra attention is needed

Comments

@18skeltor
Copy link

This is a great extension but unfortunately it doesn't seem to be translating the text to English :(

The proxy is http://localhost:8080/, I didn't change anything, but I only get romaji

@Richie-Z
Copy link
Owner

Richie-Z commented Mar 25, 2024

@18skeltor
Since the Spicetify extension runs in the browser then accessing Google Translate API requires a proxy for bypass the CORS issue. The quick solution to overcome that issue, is using cors-anywhere.

Currently I don't have a server to host a cors-anywhere, but there is a demo to access cors-anywhere, you can request the demo in this site after that you can change the proxy from http://localhost:8080 to https://cors-anywhere.herokuapp.com/

@Richie-Z Richie-Z pinned this issue Mar 25, 2024
@todayisyokult
Copy link

todayisyokult commented Apr 11, 2024

@Richie-Z Since the Spicetify extension runs in the browser then accessing Google Translate API requires a proxy for bypass the CORS issue. The quick solution to overcome that issue, is using cors-anywhere.

Currently I don't have a server to host a cors-anywhere, but there is a demo to access cors-anywhere, you can request the demo in this site after that you can change the proxy from http://localhost:8080 to https://cors-anywhere.herokuapp.com/
————————————————————————————

does it means
After i applyed the temporary access to the demo server
image

then copy“https://cors-anywhere.herokuapp.com/” and fills into CORS Proxy?
image
🤔️
thank you for your answer

@Richie-Z
Copy link
Owner

@Richie-Z Since the Spicetify extension runs in the browser then accessing Google Translate API requires a proxy for bypass the CORS issue. The quick solution to overcome that issue, is using cors-anywhere.
Currently I don't have a server to host a cors-anywhere, but there is a demo to access cors-anywhere, you can request the demo in this site after that you can change the proxy from http://localhost:8080 to https://cors-anywhere.herokuapp.com/
————————————————————————————

does it means After i applyed the temporary access to the demo server image

then copy“https://cors-anywhere.herokuapp.com/” and fills into CORS Proxy? image 🤔️ thank you for your answer

yup, but remember the cors-anywhere heroku is has very limited trials.
maybe you can use my free self-served cors-anywhere: https://web-production-05c1.up.railway.app/

@bentohere
Copy link

I've tried to fill in the CORS Proxy box with https://web-production-05c1.up.railway.app/ and https://cors-anywhere.herokuapp.com, but neither the romanji nor the translation worked. Do you know how to trigger the change?

@todayisyokult
Copy link

todayisyokult commented Jun 13, 2024

I've tried to fill in the CORS Proxy box with https://web-production-05c1.up.railway.app/ and https://cors-anywhere.herokuapp.com, but neither the romanji nor the translation worked. Do you know how to trigger the change?

maybe you can try lyric plus(https://spicetify.app/docs/advanced-usage/custom-apps/#lyrics-plus)
image
or this Extensions
image

@bentohere
Copy link

I've tried to fill in the CORS Proxy box with https://web-production-05c1.up.railway.app/ and https://cors-anywhere.herokuapp.com, but neither the romanji nor the translation worked. Do you know how to trigger the change?

maybe you can try lyric plus(https://spicetify.app/docs/advanced-usage/custom-apps/#lyrics-plus) image or this Extensions image

I now have the Beautiful Lyrics extension for the romanization needs. Lyrics Plus only provides translation to Chinese on mine, so I was looking for an extension that has both romanization and translation features actually works.

@Richie-Z
Copy link
Owner

I've tried to fill in the CORS Proxy box with https://web-production-05c1.up.railway.app/ and https://cors-anywhere.herokuapp.com, but neither the romanji nor the translation worked. Do you know how to trigger the change?

I don't know if this will answering or not but I will answer it. Now to show the lyrics we must have a premium account 😢, so this extension will not works if we don't have a premium account.

Currently working on integrating the free lyric providers to replace the current Spotify lyric provider.

@bentohere
Copy link

I've tried to fill in the CORS Proxy box with https://web-production-05c1.up.railway.app/ and https://cors-anywhere.herokuapp.com, but neither the romanji nor the translation worked. Do you know how to trigger the change?

I don't know if this will answering or not but I will answer it. Now to show the lyrics we must have a premium account 😢, so this extension will not works if we don't have a premium account.

Currently working on integrating the free lyric providers to replace the current Spotify lyric provider.

Thanks for the response! My account is premium already, though. I'm not sure what these all should be, but that would be very awesome if an update would fix this. It's promising after all. :D

@Richie-Z
Copy link
Owner

I've tried to fill in the CORS Proxy box with https://web-production-05c1.up.railway.app/ and https://cors-anywhere.herokuapp.com, but neither the romanji nor the translation worked. Do you know how to trigger the change?

I don't know if this will answering or not but I will answer it. Now to show the lyrics we must have a premium account 😢, so this extension will not works if we don't have a premium account.
Currently working on integrating the free lyric providers to replace the current Spotify lyric provider.

Thanks for the response! My account is premium already, though. I'm not sure what these all should be, but that would be very awesome if an update would fix this. It's promising after all. :D

My account is on the free plan, so I can't figure it out what's causing this failure 😢

@DhruvSinha2003
Copy link

DhruvSinha2003 commented Jun 23, 2024

Currently working on integrating the free lyric providers to replace the current Spotify lyric provider.

How long do you think this will take?

@Richie-Z
Copy link
Owner

Update: I've bought the premium, and the extension still working fine
@bentohere

image

@Richie-Z
Copy link
Owner

How long do you think this will take?

@DhruvSinha2003 Soon enough, maybe in the late of June or early July 🤔

@Richie-Z
Copy link
Owner

For anyone who can't see the translation, that's because the translator API need to through CORS proxy to access the functionalities.

Currently I have made the default CORS Proxy to my free plan railway app of cors-anywhere (da4fcef). But since it's on the free plan, the changes of quota has run out is high, so I advise to do self hosted cors-anywhere on railway.app

@bentohere
Copy link

Update: I've bought the premium, and the extension still working fine @bentohere

image

image

image
Thank you for the update. It just, did nothing. The link is always on the box (How do I put it, like, the link is always there; not disappear once I close the Spotify app). I've requested temporary access to https://cors-anywhere.herokuapp.com/corsdemo as well.

@Richie-Z
Copy link
Owner

Richie-Z commented Jun 24, 2024

Hmm, that's a weird case. Because everything that you mention supposedly it works (related to the meme: but, in my computer is works 😂).

Maybe you can send me the console message.
To achieve this you need enable the devtools by typing this spicetify enable-devtools in your terminal.

  • And then open lyric box,
  • right click to any of it,
  • and go to the console sections.

to see your saved value of the CORS proxy or any of it, you can go to Application->Local Storage->Type romajin in the filter input box
image

cc @bentohere

@Richie-Z Richie-Z added the help wanted Extra attention is needed label Jun 24, 2024
@bentohere
Copy link

Hmm, that's a weird case. Because everything that you mention supposedly it works (related to the meme: but, in my computer is works 😂).

Maybe you can send me the console message. To achieve this you need enable the devtools by typing this spicetify enable-devtools in your terminal.

  • And then open lyric box,
  • right click to any of it,
  • and go to the console sections.

to see your saved value of the CORS proxy or any of it, you can go to Application->Local Storage->Type romajin in the filter input box image

cc @bentohere

Woah, I appreciate the help! Is this it?
image

image

@Richie-Z
Copy link
Owner

Woah, I appreciate the help! Is this it? image

image

Yep, that's it.
But I don't saw any error messages produced by Romajin in your console. Are the lyric box is already opened? and for make sure can you give me your installed extensions or custom apps so I can reproduce it myself

@DhruvSinha2003
Copy link

any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants