Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bevy 0.14 #70

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Update to Bevy 0.14 #70

merged 1 commit into from
Sep 3, 2024

Conversation

msklosak
Copy link
Contributor

@msklosak msklosak commented Jul 6, 2024

This PR updates bevy-console to Bevy 0.14, bumping the version to 0.12.0.

Fixes #69

@IamTheCarl
Copy link

I decided to try this PR myself.
It was pretty much a drop-in replacement with no modifications needed.
The only oddity is that for some reason my terminal is now transparent...
image

I haven't had a chance to check yet but I suspect Color32 is either not being constructed correctly or there's a bug in egui.
https://github.com/RichoDemus/bevy-console/blob/main/src/console.rs#L256

@TarekAS
Copy link

TarekAS commented Aug 10, 2024

Works for me as well

@robtfm
Copy link

robtfm commented Aug 13, 2024

i get crashes on exit from egui_context.ctx_mut(), can we change them to let Some(ctx) = egui_contexts.try_ctx_mut() else { return; } please

@makspll
Copy link
Collaborator

makspll commented Sep 3, 2024

Awesome work, thanks a lot! I'll merge and address the issues after

@makspll makspll merged commit 4c54932 into RichoDemus:main Sep 3, 2024
1 check passed
@makspll
Copy link
Collaborator

makspll commented Sep 3, 2024

Hmm, @IamTheCarl Which version of bevy_console were you using previously, we've had a PR which added customisation options and it seems the default color is indeed transparent:

Color32::from_black_alpha(102),

@msklosak msklosak deleted the bevy_014 branch September 7, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Bevy v0.14
5 participants