Fix TypeMapper UseReference not used when mapping a GenericType #1762
Conversation
|
It should also fix #1046 |
|
Please let me know if you want me to fix anything, I was doubting a bit on the test, on whether it's clear enough. |
|
@RicoSuter did you have time to take a look at this? Let me know if I need to change anything or add more unit tests 🙂 |
desjoerd
force-pushed
the
fix/generic-type-mapper-use-reference
branch
from
b1f850d to
3b4e3ad
Compare
|
I was reviewing my code and I had some weird changes in the unit test. I fixed those. Hopefully it's now good to merge 👍 |
|
Yes I believe so. Full framework expected mono to be installed and it is not in new ubuntu 24.04 runners. |
|
Can you requeue the checks? Because I don't see the option. It would be really nice to have this PR merged, and maybe released together with the package updates. |
|
If you merge latest master to this branch there's a chance for build to succeed. |
desjoerd
force-pushed
the
fix/generic-type-mapper-use-reference
branch
from
3b4e3ad to
814c101
Compare
|
I rebased, but github doesn't queue the PR build automatically. The workflow is awaiting approval. |
|
Thank you. |
When using Generic TypeMappers the UseReference property was not used. This causes problems when using primitives (and string) which do not use references.
fixes #1302
fixes #1046