- fix issue in bs4DashSidebar (wrong href attr)

RinteRface · Apr 29, 2020 · 7d5569d · 7d5569d
1 parent c4a8a9f
commit 7d5569d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -47,6 +47,7 @@ To keep it open, see below
 - change `bs4TabPanel()` param order to align with shiny
 
 ## Bug Fix
+- Fix issue in `bs4DashSidebar()` url link. Thanks @pvictor
 - Fix #30: programmatically close `bs4Alert()`
 - Fix #47: Control bar not showing top elements when collapsed is FALSE
 - Fix #99: rework the way sidebar items work. By default, when sidebar items has subitems and is selected, the first item is not selected. We leave the choice to the user. Thanks @analytichealth

diff --git a/R/dashboardSidebar.R b/R/dashboardSidebar.R
@@ -30,7 +30,7 @@ bs4DashSidebar <- function(..., inputId = NULL, disable = FALSE,
   brandTag <- if (!is.null(title)) {
     shiny::tags$a(
       class = if (!is.null(brandColor)) paste0("brand-link bg-", brandColor) else "brand-link",
-      href = url,
+      href = if (!is.null(url)) url else "#",
       shiny::tags$img(
         src = src,
         class = "brand-image img-circle elevation-3",

diff --git a/docs/news/index.html b/docs/news/index.html
diff --git a/docs/pkgdown.yml b/docs/pkgdown.yml
@@ -6,5 +6,5 @@ articles:
   bs4Themes: bs4Themes.html
   bs4cards: bs4cards.html
   bs4sortable: bs4sortable.html
-last_built: 2020-04-29T21:47Z
+last_built: 2020-04-29T21:52Z