[ASKRS-10] Brand Setting #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riazosama
requested changes
Jan 13, 2025
src/app/(admin)/dashboard/_components/DashboardSideBar/DashboardSideBar.tsx
Outdated
Show resolved
Hide resolved
src/app/(admin)/dashboard/_components/DashboardSideBar/DashboardSideBar.tsx
Outdated
Show resolved
Hide resolved
src/app/(admin)/dashboard/_components/DashboardSideBar/DashboardSideBar.tsx
Outdated
Show resolved
Hide resolved
src/app/(admin)/dashboard/_components/DashboardSideBar/DashboardSideBar.tsx
Show resolved
Hide resolved
src/app/(admin)/dashboard/_components/DashboardSideBar/DashboardSideBar.tsx
Outdated
Show resolved
Hide resolved
src/app/(admin)/dashboard/brandsettings/_components/MainPreview/MainPreview.tsx
Outdated
Show resolved
Hide resolved
riazosama
reviewed
Jan 14, 2025
There was a problem hiding this comment.
- By default Theme accordion should be expandable
- When on brand page this side bar item should be selected:
- On small screens, when Theme accordion is in expanded state, I can scroll. See the Loom. This should be happen
https://www.loom.com/share/a07ef909ed9e45c88bb16b6106cfaa90
src/app/(admin)/dashboard/_components/DashboardSideBar/DashboardSideBar.tsx
Show resolved
Hide resolved
src/app/(admin)/dashboard/brandsettings/_components/BrandAccordion.tsx
Outdated
Show resolved
Hide resolved
src/app/(admin)/dashboard/brandsettings/_components/BrandAccordion.tsx
Outdated
Show resolved
Hide resolved
src/app/(admin)/dashboard/brandsettings/_components/BrandAccordion.tsx
Outdated
Show resolved
Hide resolved
src/app/(admin)/dashboard/brandsettings/_components/BrandAccordion.tsx
Outdated
Show resolved
Hide resolved
src/app/(admin)/dashboard/brandsettings/_components/BrandAccordion.tsx
Outdated
Show resolved
Hide resolved
src/app/(admin)/dashboard/brandsettings/_components/BrandAccordion.tsx
Outdated
Show resolved
Hide resolved
src/app/(admin)/dashboard/brandsettings/_components/BrandAccordion.tsx
Outdated
Show resolved
Hide resolved
riazosama
requested changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Designed the Brand Setting page
Related Issue
https://issues.internal.ripeseed.io/ripeseed/projects/90932f61-03d9-45c9-a819-08f9178236fc/issues/e9e45a4a-2825-4f39-8cc3-ed359c8b1239
Type of Change
How Has This Been Tested?
Locally on desktop only
Checklist:
Screenshots (if appropriate):
n/a
Additional Notes:
page route:http://localhost:3000/dashboard/brandsettings