Improve the process of inserting changes into the database #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YourOrdinaryCat
added
enhancement
|
hey cat, this looks promising! can’t wait to see what comes next! Also, there is an issue where the app hangs on startup before the scanning teachingtip or any ui appears. Are you aware of this and trying to fix it? |
|
I'm aware of that, I'm guessing some operations are blocking the UI thread (probably settings related). I'm gonna work on lifecycle management as well, so that'll definitely be getting improvements! |
|
Ah thanks for keeping me in the know! Try and have a look at this ASAP if you can (want this to be fixed in the next day or two if possible) |
…yCat/Rise-Media-Player into main-(insider_bloom)
|
WHY DID IT MERGE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
This begins work on #131.
Details of Changes
In #131, this is expected to resolve item 2 (instead of inserting to the DB and the media collections at the same time, insert everything into DB first, and when we're done, get data from there) and possibly item 1 (Implement background change tracking). This round of changes is gonna be pretty big, so it's gonna live in a PR and likely stay here for a while.
Validation
Not tested yet.
Screenshots / Videos (optional)
None yet, these are backend changes.