Merge pull request #1060 from RoadieHQ/fix-jsonata-error-handling

fix jsonata error handling
RoadieHQ · Jul 21, 2023 · 1ca38a6 · 1ca38a6
2 parents 8390d7d + 88c96b8
commit 1ca38a6
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/.changeset/violet-flowers-attack.md b/.changeset/violet-flowers-attack.md
@@ -0,0 +1,5 @@
+---
+'@roadiehq/scaffolder-backend-module-utils': patch
+---
+
+Adds error handling for the `JSONata` scaffolder action.
diff --git a/plugins/scaffolder-actions/scaffolder-backend-module-utils/src/actions/jsonata/jsonata.ts b/plugins/scaffolder-actions/scaffolder-backend-module-utils/src/actions/jsonata/jsonata.ts
@@ -61,10 +61,19 @@ export function createJSONataAction() {
       },
     },
     async handler(ctx) {
-      const expression = jsonata(ctx.input.expression);
-      const result = expression.evaluate(ctx.input.data);
+      try {
+        const expression = jsonata(ctx.input.expression);
+        const result = expression.evaluate(ctx.input.data);
 
-      ctx.output('result', result);
+        ctx.output('result', result);
+      } catch (e: any) {
+        const message = e.hasOwnProperty('message')
+          ? e.message
+          : 'unknown JSONata evaluation error';
+        throw new Error(
+          `JSONata failed to evaluate the expression: ${message}`,
+        );
+      }
     },
   });
 }